Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming than 'tags' #49

Closed
tmcw opened this issue Mar 27, 2013 · 3 comments
Closed

Better naming than 'tags' #49

tmcw opened this issue Mar 27, 2013 · 3 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Mar 27, 2013

The raster-colorizer type is currently tags - not sure if this really makes sense - sure, it's tags, but lots of other things, like text placements, will be tags as well, and should have type checking so that you can't specify color stops as text placements and so on.

Types are also usually named by carto input rather than serialization.

Thinking a better name might be stops?

/cc @springmeyer

@artemp
Copy link
Member

artemp commented Mar 27, 2013

color-stops ?

On 27 March 2013 15:23, Dane Springmeyer [email protected] wrote:

Sounds good. I think the 'tags' term came from your original patch for
this support. If not I have no idea where they came from.


Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-15529818
.

@springmeyer
Copy link
Member

+1 to color-stops

@springmeyer
Copy link
Member

tags are still used internally. not actionable to change this without renewed need/interest. closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants