Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[user interface]: Use .png as the XYZ Tile URL format hint for raster & raster-dem tiles #952

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

roblabs
Copy link
Contributor

@roblabs roblabs commented Oct 31, 2024

Launch Checklist

  • Briefly describe the changes in this PR.
  • When adding a new Raster or Raster-dem tile source, use .png as the hint for the tile URL hint prompt.
    • Currently, the user is prompted for a Vector tile source (e.g., .pbf)
  • If a new Mapnik user already has their XYZ raster Tile URL, then they may already know how to modify this text field.
  • This change may be useful for new users and is intended for them.
  • .png is a start. It could be .webp or .jpg, or .jpg, or in the case of Esri there is no extension for the images.

  • Include before/after visuals or gifs if this PR includes visual changes.
  • Steps to reproduce
  • See RobLabs.com/maputnik for a working version of this fix for Maputnik
    • On top menu bar: Data Sources > In the Add New Source section > Change Source Type to "Raster (Tile URLs)"
      • There you will see prompt hint for a raster Tile instead of vector tile .pbf.
  • See the release notes for the National Park Service prototype release for Maputnik for National Park Service Park Tiles for more screen shots.

Before

.pbf may be confusing for those adding a Raster

image

After

image


  • Write tests for all new functionality.
  • See screen shots for functionality
  • [] Add an entry to CHANGELOG.md under the ## main section.
    Not really a feature, so I will leave this out
  • Link to related issues.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HarelM HarelM merged commit 687f9ab into maplibre:main Oct 31, 2024
7 checks passed
@roblabs roblabs deleted the raster_prompt_PNG branch October 31, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants