Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mlt-vector-tile-js #212

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Conversation

ebrelsford
Copy link
Collaborator

This PR adds a way to wrap MLT tiles in a similar API to mapbox/vector-tile-js, which makes it possible to use MLTs in MapLibre GL JS. Eventually we would expect this to be a separate package but since this is experimental and the MLT API is changing we think it's reasonable to incubate this here for now.

@ebrelsford ebrelsford requested a review from springmeyer June 27, 2024 15:02
js/package.json Outdated Show resolved Hide resolved
js/src/index.ts Outdated Show resolved Hide resolved
js/src/mlt-vector-tile-js/VectorTileLayer.ts Outdated Show resolved Hide resolved
js/src/mlt-vector-tile-js/VectorTileLayer.ts Outdated Show resolved Hide resolved
@ebrelsford ebrelsford requested a review from springmeyer June 27, 2024 17:37
@ebrelsford
Copy link
Collaborator Author

@springmeyer I think I got to everything here, appreciate you taking a look at it!

@springmeyer
Copy link
Collaborator

Okay thanks. Will have a chance to take a look in about 1.5 hrs.

Copy link
Collaborator

@springmeyer springmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just caught a few other things that look unneeded.

@ebrelsford ebrelsford enabled auto-merge (squash) June 28, 2024 12:44
@ebrelsford ebrelsford merged commit 97af75b into maplibre:main Jun 28, 2024
8 checks passed
@ebrelsford ebrelsford deleted the add-mlt-vector-tile-js branch June 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants