Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.0.1-alpha.2 #207

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@ebrelsford ebrelsford closed this Jun 26, 2024
@ebrelsford ebrelsford reopened this Jun 26, 2024
@ebrelsford ebrelsford enabled auto-merge (squash) June 26, 2024 17:43
@ebrelsford ebrelsford merged commit 65d8411 into main Jun 26, 2024
8 checks passed
@ebrelsford ebrelsford deleted the bump-version-to-0.0.1-alpha.2 branch June 26, 2024 17:48
@ebrelsford
Copy link
Collaborator

@HarelM Is there anything we have to do on the NPM side to make this work? I see an error when publishing:

[...]
npm notice integrity:     sha512-/1GMc2K3Mg5g/[...]fUyykhG75YgtQ==     
npm notice total files:   97                                           
npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag next and default access
npm ERR! code E402
npm ERR! 402 Payment Required - PUT https://registry.npmjs.org/@maplibre%2fmaplibre-tile-spec - You must sign up for private packages

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-06-26T17_49_47_369Z-debug-0.log
Error: Process completed with exit code 1.

@HarelM
Copy link

HarelM commented Jun 26, 2024

Maybe there's a need to add: --access public
Since this is a scoped package.

@nyurik
Copy link
Member

nyurik commented Jun 26, 2024

One potential issue i see with this setup is that we have multiple language implementations in the same repo - and most of the time their releases will not coincide... How will we want to handle that?

@HarelM
Copy link

HarelM commented Jun 26, 2024

This release is only relevant to JavaScript, you can either create multiple yaml files or add more logic to the existing yaml actions.

ebrelsford added a commit that referenced this pull request Jun 26, 2024
As suggested in #207, this may be necessary since this is a scoped
package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants