feat: extract android UserLocation FPS #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekmeissner
changed the title
marekmeissner
changed the title
caspg
reviewed
Sep 9, 2024
...d/rctmln/src/main/java/com/maplibre/rctmln/components/location/LocationComponentManager.java
Show resolved
Hide resolved
caspg
approved these changes
Sep 9, 2024
|
@caspg I updated CHANGELOG in the latest commit to match rules |
|
@marekmeissner, thank you for this. Useful feature, and the docs and test coverage are appreciated. Will go out in 10.0.0-alpha.12. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
# [10.0.0-beta.1](v9.1.0...v10.0.0-beta.1) (2024-12-02) ### Bug Fixes * add @babel/plugin-transform-private-methods for jest ([3a2188f](3a2188f)) * add generic expo config plugin to remove duplicate signature ([#453](#453)) ([2671381](2671381)) * allow MapView and Images to have no children ([#521](#521)) ([1e35bf6](1e35bf6)) * allow resetting contentInset with 0 ([#468](#468)) ([1fe42c6](1fe42c6)) * android example crashing on launch ([#372](#372)) ([aeef5c3](aeef5c3)) * cleanup yarn setup ([#463](#463)) ([d9a4d30](d9a4d30)) * corepack enable on publish workflow ([2d13f33](2d13f33)) * correct types in MapView ([#268](#268)) ([0ea35c4](0ea35c4)) * disable code signing for release builds ([b3cf088](b3cf088)) * disable library code signing ([22030dd](22030dd)) * empty pbxproj and dwarf-with-dsym plugin config for EAS ([#458](#458)) ([0d54b46](0d54b46)) * expo-app should load library from workspace:. ([016b44a](016b44a)) * group dependabot commits by core, dev and example ([#165](#165)) ([b697978](b697978)) * keep [@ts-ignore](https://github.com/ts-ignore) for headingIcon in library [#476](#476) ([#477](#477)) ([ef62454](ef62454)) * make MarkerView props with defaults optional ([#460](#460)) ([185cf3e](185cf3e)) * plugin for debug simulator ([#164](#164)) ([06b23d4](06b23d4)) * remove AbortController test mock ([#403](#403)) ([698b558](698b558)) * round compass margins and attribution position to nearest integers [android] ([#294](#294)) ([c89c842](c89c842)) * setMaxAnimationFps on null ([#440](#440)) ([2884256](2884256)) * style expressions ([#466](#466)) ([2202908](2202908)) * updated Mapbox callstack check for iOS custom headers to check for MapLibre instead ([#461](#461)) ([a6d6216](a6d6216)) * use UIManager exported from react-native ([#511](#511)) ([a4030b5](a4030b5)) * yarn implementation ([#419](#419)) ([39233b1](39233b1)) ### Continuous Integration * add semantic release ([#526](#526)) ([069b6c5](069b6c5)) ### Features * align react and react-native versions for development ([b92abfe](b92abfe)) * configure packages/examples ([c4510c3](c4510c3)) * extract android UserLocation FPS ([#428](#428)) ([8c0abaa](8c0abaa)) * make Camera pure ([#471](#471)) ([23ecf88](23ecf88)) * MapLibre Android SDK 11.5.0 ([#455](#455)) ([042b759](042b759)) * monorepo configuration ([343e7ac](343e7ac)) * mv example packages/react-native-app ([5c9d3d0](5c9d3d0)) * mv examples, styles, assets, utils and scenes to packages/examples ([13600fe](13600fe)) * packages/expo-app ([c01abd5](c01abd5)) * setup build step ([#504](#504)) ([a017d64](a017d64)) * shared dependencies through packages/examples ([01a9586](01a9586)) * support new arch through interop layer ([#483](#483)) ([951e9cf](951e9cf)) * update maplibre native version ([#61](#61)) ([25c418a](25c418a)) * upgrade [@Turf](https://github.com/turf) to v7 and remove geo utils ([#478](#478)) ([a45fc55](a45fc55)) ### BREAKING CHANGES * Upgrade native packages and migrate components * ci: move native builds to review * ci: run release immediate for debugging * ci: use android working directory for build * docs: remove RELEASE.md * chore: remove manual changelog task * ci: enable release on beta branch * ci: keep default tagFormat * ci: setup npm tag fixes * ci: run review on mr to beta * ci: run fix tags on beta * ci: fix name * ci: clarify workflow_call * ci: disable debugging * ci: run fix tags in pr * ci: setup fix tags to run on beta * docs: prepare changelog for semantic-release * ci: remove fix npm tags workflow
|
🎉 This PR is included in version 10.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
androidPreferredFramesPerSecondprop for UserLocation that allows to set max FPS for user location animation. This allows to improve performance especially on low-end android devices.Change is based on research of maplibre-native
LocationComponent.java, which serves and encourages to usesetMaximumFpsmethod for this feature purpose.Checklist
yarn lint:fixin the root folderyarn testin the root folderyarn generatein the root folderCHANGELOG.mdindex.d.ts)/example)Screenshot OR Video
android-location-fps.mp4