Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Duplicated Signature issue with Xcode 15 #12022 #238

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix: Duplicated Signature issue with Xcode 15 #12022 #238

merged 2 commits into from
Feb 28, 2024

Conversation

tyrauber
Copy link
Collaborator

@tyrauber tyrauber commented Jan 31, 2024 •
edited
Loading

Description

The library fails in Expo with Xcode 15 due to CocoaPods/issues/12022

This PR addresses the issue by delete the duplicate signature file in the build phase.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

@gorbypark gorbypark mentioned this pull request Jan 31, 2024
Closed
@tyrauber
Copy link
Collaborator Author

tyrauber commented Feb 2, 2024

@sarahsporck, before we merge this, let me confirm it is still necessary against SDK 10.2.0.

jxeeno
jxeeno reviewed Feb 3, 2024
View reviewed changes
@tyrauber tyrauber force-pushed the fix/pluginXcode15 branch 2 times, most recently from c62f20d to 72d4ed1 Compare February 3, 2024 15:29
@tyrauber
Fix: Duplicated Signature issue with Xcode 15
f9be8b0 
- chore: update changelog
- fix: withoutSignatures should effect all builds
@andrei-tofan
Copy link
Contributor

More details about the issue can be found here:
CocoaPods/CocoaPods#12022

sarahsporck
sarahsporck approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!
Strange that this doesn't happen, when building the example repo 🤔

@tyrauber
Copy link
Collaborator Author

@sarahsporck, the example repo is a react-native app and not an expo app so it doesn't use the expo plugin. It's probably because the react-native app is using an older version of cocoapods? Or maybe < iOS 17?

@tyrauber tyrauber merged commit 78e97a0 into maplibre:main Feb 28, 2024
4 checks passed
@aLemonFox
Copy link

Thanks for the work everyone!

@tyrauber tyrauber deleted the fix/pluginXcode15 branch February 28, 2024 13:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marosstudenic
Copy link

Hey, I just updated to Xcode 16, and I got the issue with
Duplicated Signature issue
Can I ask are you planning to move this workaround also to new version of Xcode, or is something misconfigured on my side ?

@KiwiKilian
Copy link
Collaborator

@marosstudenic are you using the latest v10 version?

@marosstudenic
Copy link

Sorry my mistake, I overlooked new version. It works now with new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxeeno jxeeno jxeeno left review comments

@aLemonFox aLemonFox aLemonFox left review comments

@sarahsporck sarahsporck sarahsporck approved these changes

Assignees
No one assigned
Labels
Released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tyrauber @andrei-tofan @aLemonFox @marosstudenic @KiwiKilian @jxeeno @sarahsporck