Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle update #611

Merged
merged 6 commits into from
Dec 17, 2022
Merged

Gradle update #611

merged 6 commits into from
Dec 17, 2022

Conversation

artakka
Copy link
Collaborator

@artakka artakka commented Dec 16, 2022

Updated the gradle plugin version from. 3.6.4 to 7.3.1
Updated Kotlin version from 1.3.72 to 1.7.20
Added multidex support
Fixed the automated build so it accepts new tool licenses
Updated android-ci-pull.yml to install the correct version of cmake

Artak Kalantarian and others added 6 commits December 15, 2022 15:31
# Conflicts:
#	platform/android/gradle/wrapper/gradle-wrapper.properties
Specify installed cmake version
Commented out thr nitpick test for vendor pin. Will enter a task to evaluate what it does and restore if needed.
Removed unused import
Added agreeing to license
Enabled mutidex to prevent command line build from failing
Copy link
Collaborator

@boldtrn boldtrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the great update 👍

@birkskyum birkskyum self-requested a review December 17, 2022 20:47
Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Fixes #483 , Fixes #336

@birkskyum birkskyum merged commit b55b311 into maplibre:main Dec 17, 2022
@wipfli wipfli mentioned this pull request Dec 18, 2022
wipfli added a commit that referenced this pull request Dec 18, 2022
@wipfli wipfli mentioned this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants