Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timestamps for image descriptor updates #3152

Merged

Conversation

adrian-cojocaru
Copy link
Collaborator

@adrian-cojocaru adrian-cojocaru commented Jan 17, 2025

Image descriptors should use timestamps to track the last update time. This prevents update skips when using shared textures between drawables.

Copy link

github-actions bot commented Jan 17, 2025

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0019         +0.0021             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3152-compared-to-main.txt

Copy link

github-actions bot commented Jan 17, 2025

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3152-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.1Mi  +438% +26.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3152-compared-to-legacy.txt

Copy link

github-actions bot commented Jan 20, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3152-compared-to-main.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review January 21, 2025 11:28
@adrian-cojocaru adrian-cojocaru enabled auto-merge (squash) January 21, 2025 19:25
@adrian-cojocaru adrian-cojocaru merged commit 4ae61fb into maplibre:main Jan 21, 2025
42 of 49 checks passed
@adrian-cojocaru adrian-cojocaru deleted the image-descriptor-timestamps branch January 23, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants