Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextureMode crash #3144

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

adrian-cojocaru
Copy link
Collaborator

@adrian-cojocaru adrian-cojocaru commented Jan 15, 2025

Reordered some surface lifecycle events to avoid rendering with no valid surface available. Fixes #3099

Reorder render thread events
@adrian-cojocaru adrian-cojocaru self-assigned this Jan 15, 2025
@adrian-cojocaru adrian-cojocaru linked an issue Jan 15, 2025 that may be closed by this pull request
@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review January 15, 2025 14:04
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add an instrumentation test that reproduces this?

Can you add some context in the PR description?

@adrian-cojocaru
Copy link
Collaborator Author

I've used Android Studio's Layout Inspector to trigger the crash since I haven't been able to consistently reproduce it with just the device events.

@louwers louwers merged commit 6c88f72 into maplibre:main Jan 21, 2025
28 checks passed
@adrian-cojocaru adrian-cojocaru deleted the texture-mode-fix branch January 21, 2025 17:59
@moodstubos
Copy link

@adrian-cojocaru
thank you very much for this fix. It resolves some Cause: null pointer dereference issues.
Question: Could you do the same for non-vulkan version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Vulkan Native Crash when using TextureMode
4 participants