Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios14 location permissions #31

Merged
merged 10 commits into from
Feb 23, 2021
Merged

ios14 location permissions #31

merged 10 commits into from
Feb 23, 2021

Conversation

petr-pokorny-1
Copy link
Contributor

resolves #29

@roblabs
Copy link
Collaborator

roblabs commented Feb 23, 2021

  1. It is really nice to have automatic checks. @petr-pokorny-1 — great job on setting up the GitHub Actions for this repo. I did some review there (but not sure how to look for issues)
  2. Tested with the schemes:
  • CI — warnings are related to GLKit
  • iosapp — warnings are related to GLKit
  • bench - failed, but I'm not sure if it failed before (seems likely)

Desktop Xcode scheme testing summary
image

@petr-pokorny-1
Copy link
Contributor Author 

* bench - failed, but I'm not sure if it failed before (seems likely)

I was able to fix benchmark app and launch it on my iphone.

Screen Shot 2021-02-23 at 1 49 30 PM

@petr-pokorny-1 petr-pokorny-1 merged commit cc2ea9f into master Feb 23, 2021
@petr-pokorny-1 petr-pokorny-1 deleted the ios14-location-permissions branch February 23, 2021 13:54
@roblabs
Copy link
Collaborator

roblabs commented Feb 23, 2021

Bench mark results on x86_64 Simulator. Thanks for fixing

Benchmark completed.
Result:

Location FPS
paris 11.5 fps
paris2 16.3 fps
alps 6.2 fps
us east 16.9 fps
greater la 11.9 fps
sf 19.1 fps
oakland 13.3 fps
germany 7.6 fps

Total FPS: 102.9
Average FPS: 12.9

nvanfleet pushed a commit to lyft/maplibre-gl-native that referenced this pull request Jul 28, 2022
@lyft-control-1
Update parent bionicbase to current version (maplibre#31)
fa5a0cb 
This PR is updating the version of this image's parent (`bionicbase`) to keep this image (`maplibreglnativeprivate`) up-to-date.
It will be merged if all tests pass via `/merge-skip-owners`; if tests do not pass, it will require manual intervention.

For more details please see the [docs about Automatic Updates](https://docs.lyft.net/eng/provisioningdocs/learning/automatic_updates.html).

[Here is what's changed in `bionicbase`](lyft/containers@5eafbd0...c64f3ac).
@louwers louwers mentioned this pull request May 7, 2024
Closed
@louwers louwers mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblabs roblabs roblabs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ios] Location Permissions in iOS 14
2 participants
@petr-pokorny-1 @roblabs