Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable accessibility on hidden compass button #3068

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ocarrascoe
Copy link
Contributor

Checking the issue 3058, it might be solved by disabling the accessibility on the hideCompass function because if the compass is hidden there is no point in showing it for the accessibility.

Testing it fixes the problem, let me know if it's useful!

Also, you can check if on the other hand, the function showCompass, you can set the opposite

self.isAccessibilityElement = YES;
self.accessibilityElementsHidden = No;

but as they are the default values, maybe it is not needed, just mind a case of being forced to hide and show the compass button in the same instance. What do you think?

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that when the compass is hidden, there's probably no expectation that the direction is included for users using Voice Over.

Thanks for your contribution, will be included in the next iOS release!

@louwers louwers enabled auto-merge (squash) December 4, 2024 18:40
Copy link

github-actions bot commented Dec 4, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +64  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3068-compared-to-main.txt

@louwers louwers merged commit 61d385b into maplibre:main Dec 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot exclude compassView from VoiceOver (accessibility) when map is not north
2 participants