iOS - Allow changing of User-Agent #2293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapLibre allows setting additional headers to be sent in network requests via
MLNNativeNetworkManager.sharedManager.sessionConfiguration
. Here a user could set up aUser-Agent
to be sent during requests. Unfortunately, inhttp_file_source.mm
, we set aUser-Agent
without checking if a user might have set one too.This prevents users from being able to set a
User-Agent
at all. In my use case for example, I have to talk to a service which expects a certainUser-Agent
, and currently I have no way to get MapLibre to use the requiredUser-Agent
.This PR resolves the issue by checking if a custom
User-Agent
has been set inMLNNativeNetworkManager.sharedManager.sessionConfiguration
first - if one is set, then that one is used, else MapLibre defaults to its own.