Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix projection matrix for raster image drawables #2242

Merged
merged 21 commits into from
Apr 17, 2024

Conversation

stefankarschti
Copy link
Collaborator

Fixes the projection matrix for raster image drawables that are not tile based. This results in correct depth output according to the layer index and sub-index.

Fixes #2189

Copy link

github-actions bot commented Apr 8, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +432  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2242-compared-to-main.txt

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Apr 8, 2024

Nice! How hard would it be to get some test coverage on this?

@stefankarschti
Copy link
Collaborator Author

Nice! How hard would it be to get some test coverage on this?

I'm looking into that.

Copy link

github-actions bot commented Apr 9, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +1.30Ki  +0.0%     +56    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2242-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +20% +23.4Mi  +406% +24.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2242-compared-to-legacy.txt

Copy link

github-actions bot commented Apr 9, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0032         +0.0033             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2242-compared-to-main.txt

@stefankarschti stefankarschti marked this pull request as ready for review April 15, 2024 12:51
@stefankarschti stefankarschti requested a review from cgalvan April 15, 2024 13:17
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

metrics/cache-style.db Show resolved Hide resolved
@stefankarschti stefankarschti merged commit 6919081 into maplibre:main Apr 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[iOS] MLNRasterStyleLayer gets cut off with mask in StyleURL file since v6.0
6 participants