Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setPixelRatio jsdocs #888

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented Jan 26, 2022

Launch Checklist

JSDocs wants type followed by variable name in function argument documentation.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2022

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 184 kB 184 kB 0 B
maplibre-gl.css 9.49 kB 9.49 kB 0 B
ℹ️ View Details No major changes

@astridx
Copy link
Contributor

astridx commented Jan 26, 2022

Oops. shouldn't the script
"lint-docs": "documentation lint src/index.ts"
in package.json have checked and noted that?

@wipfli
Copy link
Contributor Author

wipfli commented Jan 26, 2022

image

@wipfli wipfli merged commit 4c42a05 into maplibre:main Jan 26, 2022
@wipfli wipfli deleted the fix-setPixelRatio-jsdocs branch January 26, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants