Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #4891 flyTo() with padding is broken for Globe #5406

Merged
merged 6 commits into from
Feb 2, 2025

Conversation

pjamessteven
Copy link
Contributor

@pjamessteven pjamessteven commented Jan 26, 2025

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@pjamessteven
Copy link
Contributor Author

need to fix tests.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (cc9f170) to head (e42a666).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5406   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         282      282           
  Lines       39050    39051    +1     
  Branches     6863     6853   -10     
=======================================
+ Hits        35907    35910    +3     
+ Misses       3016     3013    -3     
- Partials      127      128    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pjamessteven pjamessteven reopened this Jan 30, 2025
@HarelM
Copy link
Collaborator

HarelM commented Feb 2, 2025

Can you show how this looks before and after the fix?
Also please add a changelog item.
The code looks good otherwise.

@pjamessteven
Copy link
Contributor Author

@HarelM
I added an entry to CHANGELOG.md.

Here's the current 5.1.0 behavior (click zoom level one and then alternate between the two padding buttons), you will see the issue):

https://jsbin.com/wihekiq/

And here is a demo of the fix:

https://jsbin.com/jaxukuz/

@HarelM
Copy link
Collaborator

HarelM commented Feb 2, 2025

Can you please check the fist checkbox in the initial comment? I can't merge without it.

@pjamessteven
Copy link
Contributor Author

Done!

@HarelM HarelM merged commit 1bb4a31 into maplibre:main Feb 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants