-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #4891 flyTo() with padding is broken for Globe #5406
Conversation
need to fix tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 282 282
Lines 39050 39051 +1
Branches 6863 6853 -10
=======================================
+ Hits 35907 35910 +3
+ Misses 3016 3013 -3
- Partials 127 128 +1 ☔ View full report in Codecov by Sentry. |
Can you show how this looks before and after the fix? |
@HarelM Here's the current 5.1.0 behavior (click zoom level one and then alternate between the two padding buttons), you will see the issue): And here is a demo of the fix: |
Can you please check the fist checkbox in the initial comment? I can't merge without it. |
Done! |
Launch Checklist
CHANGELOG.md
under the## main
section.