Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the coverage for jest to be aligned with render tests #3615

Merged
merged 7 commits into from
Jan 27, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jan 24, 2024

Launch Checklist

Related to:

Related to this discussion cenfun/monocart-coverage-reports#4

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa7372f) 83.28% compared to head (d13e3db) 87.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3615      +/-   ##
==========================================
+ Coverage   83.28%   87.31%   +4.02%     
==========================================
  Files         244      241       -3     
  Lines       32223    32218       -5     
  Branches     4398     2264    -2134     
==========================================
+ Hits        26837    28130    +1293     
+ Misses       5138     3173    -1965     
- Partials      248      915     +667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jest.config.ts Outdated Show resolved Hide resolved
@HarelM HarelM marked this pull request as ready for review January 25, 2024 07:57
@HarelM HarelM requested review from cenfun and louwers and removed request for cenfun January 25, 2024 07:57
@HarelM HarelM merged commit ac3cedc into main Jan 27, 2024
15 checks passed
@HarelM HarelM deleted the jest-coverage branch January 27, 2024 07:04
@HarelM HarelM mentioned this pull request Jun 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants