Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing error when consuming maplibre-gl with TypeScript compiler … #2600

Closed
wants to merge 3 commits into from
Closed

Fix typing error when consuming maplibre-gl with TypeScript compiler … #2600

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
758b345
Fix typing error when consuming maplibre-gl with TypeScript compiler …
neodescis May 26, 2023
7dcd245
Update changelog
neodescis May 26, 2023
2b9164c
Remove changelog entry
neodescis May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
### 🐞 Bug fixes
- Fix `RequestTransformFunction` type to return RequestParameters or undefined ([#2586](https://github.com/maplibre/maplibre-gl-js/pull/2586))
- Load `EXT_color_buffer_float` WebGL2 extension to fix heatmap in firefox ([#2595](https://github.com/maplibre/maplibre-gl-js/pull/2595))

- Fix typing error when consuming maplibre-gl with TypeScript compiler set to strict mode ([#2600](https://github.com/maplibre/maplibre-gl-js/pull/2600))
HarelM marked this conversation as resolved.
Show resolved Hide resolved

## 3.0.0

Expand Down
2 changes: 1 addition & 1 deletion src/gl/value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export class BindElementBuffer extends BaseValue<WebGLBuffer> {
}

export class BindVertexArray extends BaseValue<WebGLVertexArrayObject> {
getDefault(): WebGLVertexArrayObject | null {
getDefault(): WebGLVertexArrayObject {
return null;
}
set(v: WebGLVertexArrayObject | null) {
Expand Down