Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3.1-pre.2 #1520

Merged
merged 2 commits into from
Aug 20, 2022
Merged

Release 2.3.1-pre.2 #1520

merged 2 commits into from
Aug 20, 2022

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Aug 20, 2022

Changelog since 2.3.1-pre.1

  • Improve expression types (#1510)
  • Improve performance for primitive size selection (#1508)
  • Fix query tests on windows (#1506)
  • Upgrade target from ES2017 to ES2019 (#1499)

@birkskyum birkskyum requested review from HarelM and wipfli August 20, 2022 16:10
@HarelM
Copy link
Collaborator

HarelM commented Aug 20, 2022

Are we good with testing the assert stuff?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2022

Bundle size report:

Size Change: +1 B
Total Size Before: 204 kB
Total Size After: 204 kB

Output file Before After Change
maplibre-gl.js 195 kB 195 kB +1 B
maplibre-gl.css 9.65 kB 9.65 kB 0 B
ℹ️ View Details No major changes

@birkskyum
Copy link
Member Author

That was actually my motivation for making the pr. I don't think it's likely to break anything in the way we approached it, but if we slipped and it does happens anyway, it would be great to quickly be able to triage and potentially roll a change back - and that becomes harder for every PR we merge in on top.

@birkskyum birkskyum changed the title Release 2.3.1 Release 2.3.1-pre.2 Aug 20, 2022
@birkskyum
Copy link
Member Author

birkskyum commented Aug 20, 2022

@HarelM , I've converted it to another pre-release, so the newest additions can also have a few more days to bake. We might be stretching the boundaries for what can be considered a patch release here.

@HarelM
Copy link
Collaborator

HarelM commented Aug 20, 2022

I'm fine either way actually, just wanted to know where you stand.
I've been testing this pre-release and I haven't seen any new warnings or exception in my code, but let's see if anything rises from the community in the next few days/couple of weeks and if nothing new rises we can release an official one.

@birkskyum birkskyum merged commit 7cb76fa into main Aug 20, 2022
@birkskyum birkskyum deleted the release-2.3.1 branch August 20, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants