Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node assert with normal error handling #1485

Merged
merged 45 commits into from
Aug 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
67822e4
remove asserts
birkskyum Aug 13, 2022
690614a
remove import of unassert
birkskyum Aug 13, 2022
8749e1f
update package-lock
birkskyum Aug 13, 2022
1237ab4
introduce naiveAssert
birkskyum Aug 13, 2022
19b76b2
import naiveAssert
birkskyum Aug 13, 2022
4e61cce
move naive_assert to own file
birkskyum Aug 13, 2022
719e3bb
remove assert check
birkskyum Aug 13, 2022
91a60c9
add stylelint dependency
birkskyum Aug 13, 2022
4631fc3
only call toString if message is defined
birkskyum Aug 13, 2022
8b14854
remove global-prefix
birkskyum Aug 14, 2022
7bf1157
install global-prefix
birkskyum Aug 14, 2022
0a60188
remove some unneeded asserts
birkskyum Aug 14, 2022
f9be051
Remove unneeded asserts
birkskyum Aug 14, 2022
8142b69
lint
birkskyum Aug 14, 2022
528bddb
console.warn missing image
birkskyum Aug 14, 2022
47867f0
replace always-failing asserts with throw
birkskyum Aug 14, 2022
dffa404
resolve assert issues
birkskyum Aug 14, 2022
5b4a241
add warnonce to worker_tile
birkskyum Aug 14, 2022
6a8a771
lint
birkskyum Aug 14, 2022
a1d711b
simplify equality check
birkskyum Aug 14, 2022
773bc7c
throw instead of naiveAssert
birkskyum Aug 14, 2022
96a9e00
throw instead of assest
birkskyum Aug 14, 2022
68b49bf
Resolve asserts
birkskyum Aug 14, 2022
ee7ed58
resolve naiveAsserts
birkskyum Aug 14, 2022
b8b936d
Add error messages
birkskyum Aug 14, 2022
4950d7e
error messages
birkskyum Aug 14, 2022
44aeec6
error messages
birkskyum Aug 14, 2022
8d94c3a
error messages
birkskyum Aug 14, 2022
8756197
revert error message in style
birkskyum Aug 14, 2022
1f7a234
fix logic in placement
birkskyum Aug 14, 2022
ffd6189
Merge branch 'change-asserts' of https://github.com/maplibre/maplibre…
birkskyum Aug 14, 2022
d742c93
style error message
birkskyum Aug 14, 2022
6a1bb89
Resolve asserts
birkskyum Aug 14, 2022
9e369ec
Error handling
birkskyum Aug 14, 2022
cc15552
resolve naiveasserts
birkskyum Aug 14, 2022
1535ede
lint
birkskyum Aug 14, 2022
38f1a21
lint
birkskyum Aug 14, 2022
273d692
Resolve asserts
birkskyum Aug 14, 2022
76178dd
lint
birkskyum Aug 14, 2022
0302703
error handling
birkskyum Aug 14, 2022
34346e2
add entry in changelog
birkskyum Aug 14, 2022
9bff597
Fix error messages
birkskyum Aug 14, 2022
85ae7b7
remove throw
birkskyum Aug 14, 2022
a4a2503
Convert collision detection to a warnOnce
birkskyum Aug 14, 2022
7390961
lint
birkskyum Aug 14, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
### ✨ Features and improvements

- *...Add new stuff here...*
- Improved error handling ([#1485](https://github.com/maplibre/maplibre-gl-js/pull/1485))
-
### 🐞 Bug fixes

Expand Down
2 changes: 0 additions & 2 deletions build/generate-struct-arrays.ts
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ export class ${structArrayClass} extends ${structArrayLayoutClass} {`);
* @private
*/
get(index: number): ${structTypeClass} {
assert(!this.isTransferred);
return new ${structTypeClass}(this, index);
}`);
}
Expand All @@ -425,7 +424,6 @@ register('${structArrayClass}', ${structArrayClass});
fs.writeFileSync('src/data/array_types.g.ts',
`// This file is generated. Edit build/generate-struct-arrays.ts, then run \`npm run codegen\`.

import assert from 'assert';
import {Struct, StructArray} from '../util/struct_array';
import {register} from '../util/web_worker_transfer';
import Point from '@mapbox/point-geometry';
Expand Down
4 changes: 0 additions & 4 deletions build/rollup_plugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import typescript from '@rollup/plugin-typescript';
import resolve from '@rollup/plugin-node-resolve';
import replace from '@rollup/plugin-replace';
import commonjs from '@rollup/plugin-commonjs';
import unassert from 'unassert-rollup-plugin';
import json from '@rollup/plugin-json';
import {terser} from 'rollup-plugin-terser';
import minifyStyleSpec from './rollup_plugin_minify_style_spec';
Expand Down Expand Up @@ -43,9 +42,6 @@ export const plugins = (production: boolean): Plugin[] => [
passes: 3
}
}),
production && unassert({
include: ['**/*'], // by default, unassert only includes .js files
}),
nodeResolve,
typescript(),
commonjs({
Expand Down
Loading