Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Update submodule #230

Closed
wants to merge 4 commits into from
Closed

Update submodule #230

wants to merge 4 commits into from

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Aug 10, 2022

Dependabot managed to trick me, so I revert the package-updates that broke the CI and start by updating the submodule so that it's version doesn't break the CI.

@birkskyum birkskyum requested a review from wipfli August 10, 2022 20:56
@wipfli
Copy link
Contributor

wipfli commented Aug 11, 2022

Thanks for the updates, @birkskyum. Does this build locally for you?

@wipfli
Copy link
Contributor

wipfli commented Aug 11, 2022

Maybe you have to update this line:

"install-gl-js-deps": "cd maplibre-gl-js/ && npm ci && tsc --outDir rollup/build/tsc",

@birkskyum
Copy link
Member Author

it seems like documentation.js is behaving as expected, but this batfish static site generator is not happy about the ' import assert json' yet, even with the barbell plugin injected

@wipfli
Copy link
Contributor

wipfli commented Aug 19, 2022

If I build on main without the added plugin from this pull request against maplibre/maplibre-gl-js#1517 I get this error:

> documentation build --pe ts --re ts --re d.ts --github --format json --sort-order alpha --config ./docs/documentation.yml --output docs/components/api.json maplibre-gl-js/src/index.ts

SyntaxError: This experimental syntax requires enabling the parser plugin: 'importAssertions' (2:42)

@wipfli
Copy link
Contributor

wipfli commented Aug 19, 2022

But removing the asserts and using the plugin seems to work...

@birkskyum
Copy link
Member Author

birkskyum commented Aug 19, 2022

I've been working on documentation.js, and it runs just fine with import asserts and all - it's even possible to make it output html instead of json, where all the documentation is browsable. The problem is in the mapbox/batfish static site generator which doesn't know how to handle import asserts it yet.

@wipfli
Copy link
Contributor

wipfli commented Aug 19, 2022

I think that's right, yes.

@wipfli
Copy link
Contributor

wipfli commented Aug 19, 2022

@birkskyum
Copy link
Member Author

birkskyum commented Aug 19, 2022

I did try that here birkskyum/batfish@93bc421 - something is still off, but it does load the plugin.

It's equivalent to adding this next to babelInclude in batfish.config.json, which can be done without modifying batfish:

		babelPlugins: [
          "@babel/plugin-syntax-import-assertions"
        ],

@birkskyum birkskyum marked this pull request as draft August 19, 2022 21:19
@birkskyum
Copy link
Member Author

This PR has come too far out of sync, so I'll make a new one when the repo is ready for a submodule change.

@birkskyum birkskyum closed this Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants