-
-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
Thanks for the updates, @birkskyum. Does this build locally for you? |
Maybe you have to update this line: maplibre-gl-js-docs/package.json Line 68 in 98222c2
|
it seems like documentation.js is behaving as expected, but this batfish static site generator is not happy about the ' import assert json' yet, even with the barbell plugin injected |
If I build on main without the added plugin from this pull request against maplibre/maplibre-gl-js#1517 I get this error:
|
But removing the asserts and using the plugin seems to work... |
I've been working on documentation.js, and it runs just fine with import asserts and all - it's even possible to make it output html instead of json, where all the documentation is browsable. The problem is in the mapbox/batfish static site generator which doesn't know how to handle import asserts it yet. |
I think that's right, yes. |
Maybe we have to put the assert plugin here? https://github.com/mapbox/batfish/blob/78938bb7638c33111806982672d93792d52ee3ce/package.json#L67 |
I did try that here birkskyum/batfish@93bc421 - something is still off, but it does load the plugin. It's equivalent to adding this next to babelPlugins: [
"@babel/plugin-syntax-import-assertions"
], |
This PR has come too far out of sync, so I'll make a new one when the repo is ready for a submodule change. |
Dependabot managed to trick me, so I revert the package-updates that broke the CI and start by updating the submodule so that it's version doesn't break the CI.