[FEATURE] Returns layer Id on Feature Tap & update NDK version to fix crash on Android 15 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zverik
suggested changes
Oct 3, 2024
maplibre_gl/ios/maplibre_gl/Sources/maplibre_gl/MapLibreMapController.swift
Outdated
Show resolved
Hide resolved
This reverts commit fdc7fa5.
This is needed to fix a crash on Android 15 due to 16k page
|
Hi @LouisRaverdy, I agree this is a much needed feature. Through, there are still unresolved conversations and it introduces breaking API changes. I'm fine if we skip 0.20.1 and directly go for a breaking 0.21.0 release but please ensure that all open conversations are solved, then I can review and merge your pr. |
Co-authored-by: Joscha <[email protected]>
LouisRaverdy
changed the title
|
@josxha Thanks, all the conversations are now resolved, I also add a fix to Android 15 crashing every time due to change to page 16k. |
josxha
approved these changes
Dec 2, 2024
gabbopalma
added a commit
to gabbopalma/flutter-maplibre-gl
that referenced
this pull request
Jan 9, 2025
…n to fix crash on Android 15 (maplibre#475)" This reverts commit 8246a84.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello MapLibre Team !
I needed to retrieve the layer Id of the feature tapped, so I've implemented it.
This is much cleaner than using the given Id to have a unique identifier and the layer id.
Best regards,
Louis