Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a timelock to the xMPL migration function (SC-4848) #4

Merged
merged 8 commits into from
Mar 2, 2022
Merged

feat: Add a timelock to the xMPL migration function (SC-4848) #4

merged 8 commits into from
Mar 2, 2022

Conversation

vbidin
Copy link
Contributor

@vbidin vbidin commented Feb 28, 2022 •
edited
Loading

Adds a timelock to the migrateAll function of the xMPL contract:

  • The owner needs to schedule a migration and wait for a minimum of 10 days before a migration can be performed.
  • Events are emitted when migrations are scheduled / cancelled to allow for easier monitoring.
  • Implementation is based on the OpenZeppelin TimelockController.
  • All existing tests are refactored to work with the new timelock functionality.

@vbidin vbidin self-assigned this Feb 28, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #4848: [xMPL] Add a timelock to the xMPL migration contract..

lucas-manuel
lucas-manuel suggested changes Mar 1, 2022
View reviewed changes
Copy link

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, small changes, wil review tests next

contracts/xMPL.sol Outdated Show resolved Hide resolved
contracts/xMPL.sol Outdated Show resolved Hide resolved
contracts/xMPL.sol Outdated Show resolved Hide resolved
contracts/xMPL.sol Outdated Show resolved Hide resolved
@vbidin vbidin requested a review from lucas-manuel March 1, 2022 22:22
lucas-manuel
lucas-manuel suggested changes Mar 2, 2022
View reviewed changes
contracts/xMPL.sol Outdated Show resolved Hide resolved
contracts/test/xMPL.t.sol Outdated Show resolved Hide resolved
contracts/test/xMPL.t.sol Outdated Show resolved Hide resolved
contracts/test/xMPL.t.sol Show resolved Hide resolved
@lucas-manuel lucas-manuel force-pushed the sc-4848-xmpl-add-a-timelock-to-the-xmpl-migration branch from adfd666 to 86afa39 Compare March 2, 2022 19:49
@lucas-manuel lucas-manuel merged commit 62b5acf into main Mar 2, 2022
@lucas-manuel lucas-manuel deleted the sc-4848-xmpl-add-a-timelock-to-the-xmpl-migration branch March 2, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-manuel lucas-manuel lucas-manuel requested changes

@JGcarv JGcarv Awaiting requested review from JGcarv

Assignees

@vbidin vbidin

Labels
Priority: Medium Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbidin @lucas-manuel