feat: Use RDTTestBase (SC-5205) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #5205: [rdt] Refactor tests to use functions for assertions. |
vbidin
reviewed
Mar 16, 2022
| address notStaker; | ||
| bytes constant ARITHMETIC_ERROR = abi.encodeWithSignature("Panic(uint256)", 0x11); | ||
|
|
||
| uint256 constant START = 10_000_000; |
| } | ||
|
|
||
| // Deposit asset into RDT | ||
| function _depositAsset(address asset_, address staker_, uint256 depositAmount_) internal { |
There was a problem hiding this comment.
I think you can remove the asset from the input parameters since it's already a state variable.
| } | ||
|
|
||
| // Transfer funds into RDT and update the vesting schedule | ||
| function _transferAndUpdateVesting(address asset_, address rdToken_, uint256 vestingAmount_, uint256 vestingPeriod_) internal { |
There was a problem hiding this comment.
I think you can remove asset and rdToken from the input parameters since they're already state variables.
Same for all the other utility functions where state variables are available.
| } | ||
|
|
||
| // Returns a valid `permit` signature signed by this contract's `owner` address | ||
| function _getValidPermitSignature(uint256 value_, address owner_, address spender_, uint256 ownerSk_, uint256 deadline_) internal returns (uint8 v_, bytes32 r_, bytes32 s_) { |
There was a problem hiding this comment.
Reorder params to match order in which they are used in the function body.
| notOwner = new Owner(); | ||
| owner = new Owner(); | ||
| asset = new MockERC20("MockToken", "MT", 18); | ||
| rdToken = new RDT("Revenue Distribution Token", "RDT", address(owner), address(asset), 1e30); | ||
| vm.warp(START); |
|
|
||
| uint256 constant sampleAssetsToConvert = 1e18; | ||
| uint256 constant sampleSharesToConvert = 1e18; | ||
|
|
||
| address staker; | ||
| address notStaker; | ||
| bytes constant ARITHMETIC_ERROR = abi.encodeWithSignature("Panic(uint256)", 0x11); |
There was a problem hiding this comment.
How about adding this to TestUtils directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a base test to remove duplicate code