feat: Add mapleGlobals setter (C4 #7)
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- alignment - take latest `proxy-factory`
|
This pull request has been linked to Shortcut Story #4274: [c4] Issue #7 - Update to use setters or make immutables. |
deluca-mike
force-pushed
the
sc-4274-c4-issue-7-update-to-use-setters
branch
from
8b79ffb to
5562c7c
Compare
|
|
||
| assertEq(factory.mapleGlobals(), address(globals)); | ||
|
|
||
| assertTrue(!notGovernor.try_mapleProxyFactory_setGlobals(address(factory), address(newGlobals))); |
There was a problem hiding this comment.
Need to add an assertTrue(!) of an emptyContract globals
lucas-manuel
changed the title
mapleGlobals setter (c4 #7)mapleGlobals setter (C4 #7)
lucas-manuel
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrations Checklist
Changelog
Function Signature Changes
Features
Events