feat: Add increase/decrease allowance functionality #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4961: [erc20] Add increaseAllowance/decreaseAllowance functions to erc20. |
vbidin
previously approved these changes
Mar 9, 2022
contracts/interfaces/IERC20.sol
Outdated
| @@ -62,6 +62,24 @@ interface IERC20 { | |||
| */ | |||
| function approve(address spender_, uint256 amount_) external returns (bool success_); | |||
|
|
|||
| /** | |||
| * @dev Function that allows one account to decrease the allowance of another account over their tokens. | |||
There was a problem hiding this comment.
Spacing should be double for NatSpec.
deluca-mike
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional functions increaseAllowance and decreaseAllowance to prevent allowance race conditions.
Addresses Trail of Bits issue: https://github.com/maple-labs/tob-audit-2022-03-07/issues/3