feat: Update to add acceptLender function (SC-9368)
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #9368: [debt-locker-v4] Add acceptLender function to DebtLocker to allow for liquidity migration contingencies. |
0xfarhaan
reviewed
Nov 2, 2022
contracts/DebtLocker.sol
Outdated
| /*************************************/ | ||
|
|
||
| function acceptLender() override external whenProtocolNotPaused { | ||
| require(msg.sender == _loanMigrator, "DL:SPL:NOT_MIGRATOR"); |
There was a problem hiding this comment.
Incorrect func selector in error string
0xfarhaan
reviewed
Nov 2, 2022
tests/DebtLocker.t.sol
Outdated
|
|
||
| loanMigrator.debtLocker_setPendingLender(address(debtLocker), address(debtLocker)); // Set pending lender in Loan to get ACL to work | ||
|
|
||
| assertTrue(!notLoanMigrator.try_debtLocker_acceptLender(address(debtLocker))); |
There was a problem hiding this comment.
Think we should assert with the correct error msg as it would have highlighted the incorrect func selector but appreciate this means adjust the LoanMigrator.sol in accounts
0xfarhaan
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.