feat: Add missing unit tests (SC-4140) #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4140: [debt-locker] Add missing unit tests as per test audit. |
lucas-manuel
force-pushed
the
sc-4140-missing-unit-tests
branch
from
0c6321c to
5ba798e
Compare
JGcarv
requested changes
Nov 25, 2021
| @@ -362,10 +382,7 @@ contract DebtLockerTests is TestUtils { | |||
| /**********************************/ | |||
| /*** Create Loan and DebtLocker ***/ | |||
| /**********************************/ | |||
lucas-manuel
pushed a commit
that referenced
this pull request
Nov 25, 2021
* feat: set up unit testing * feat: set up unit testing * feat: finished unit testing, all passing * chore: rebase and do fixes
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 1, 2021
* feat: set up unit testing * feat: set up unit testing * feat: finished unit testing, all passing * chore: rebase and do fixes
lucas-manuel
pushed a commit
that referenced
this pull request
Dec 1, 2021
* feat: Latest Maple Proxy Factory - no need for nonces or create2 for debt lockers * feat: More Cleanup - take latest `maple-proxy-factory` (to be discussed) - added missing prototypes to `IDebtLockerFactory` interface - fixed some test names - test TODOs - reordered some functions * feat: Add missing unit tests (SC-4140) (#30) * feat: set up unit testing * feat: set up unit testing * feat: finished unit testing, all passing * chore: rebase and do fixes * fix: test cases, dos failing * fix: dos prevention test Co-authored-by: Michael De Luca <[email protected]> Co-authored-by: JG Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrations Checklist
Changelog
Function Signature Changes
Features
Events