Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable #3497

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Nov 1, 2024

No description provided.

@sbrunner sbrunner requested a review from sebr72 November 1, 2024 08:34
@sbrunner sbrunner changed the base branch from master to 3.31 November 1, 2024 08:43
@sbrunner sbrunner added the backport master Backport the pull request to the 'master' branch label Nov 1, 2024
@sbrunner sbrunner marked this pull request as ready for review November 1, 2024 09:27
@sbrunner sbrunner requested a review from gberaudo November 1, 2024 11:35
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 406 status code and add test

@sbrunner sbrunner changed the title Use getRawStatusCode to don't get an exception on fake status code 999 Use getRawStatusCode to don't get an exception on fake status code 999, convert it to 406 Not Acceptable Nov 1, 2024
@sebr72 sebr72 changed the title Use getRawStatusCode to don't get an exception on fake status code 999, convert it to 406 Not Acceptable Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable Nov 1, 2024
@sebr72 sebr72 force-pushed the no-exception branch 2 times, most recently from 5a0e1c7 to e07994a Compare November 3, 2024 02:00
@sbrunner
Copy link
Member Author

sbrunner commented Nov 4, 2024

Is it ready to be merged?

@sebr72
Copy link
Contributor

sebr72 commented Nov 4, 2024

@sbrunner If you are satisfied with my changes, please go ahead with the merge.

@sbrunner sbrunner merged commit 55f4202 into 3.31 Nov 4, 2024
9 checks passed
@sbrunner sbrunner deleted the no-exception branch November 4, 2024 08:43
@c2c-bot-gis-ci-2 c2c-bot-gis-ci-2 removed the backport master Backport the pull request to the 'master' branch label Nov 4, 2024
@geo-ghci-int geo-ghci-int bot added this to the 3.31.2 milestone Nov 4, 2024
@sbrunner sbrunner added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants