-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
no-exception
branch
from
November 1, 2024 08:42
ecf1546
to
4706899
Compare
sbrunner
added
the
backport master
Backport the pull request to the 'master' branch
label
Nov 1, 2024
sbrunner
force-pushed
the
no-exception
branch
from
November 1, 2024 08:56
4706899
to
ffaaa47
Compare
gberaudo
approved these changes
Nov 1, 2024
sebr72
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 406 status code and add test
sbrunner
force-pushed
the
no-exception
branch
from
November 1, 2024 11:40
ffaaa47
to
6e9e764
Compare
sebr72
requested changes
Nov 1, 2024
core/src/main/java/org/mapfish/print/map/tiled/CoverageTask.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/map/tiled/CoverageTask.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/map/image/AbstractSingleImageLayer.java
Show resolved
Hide resolved
sbrunner
changed the title
Use getRawStatusCode to don't get an exception on fake status code 999
Use getRawStatusCode to don't get an exception on fake status code 999, convert it to 406 Not Acceptable
Nov 1, 2024
sbrunner
force-pushed
the
no-exception
branch
from
November 1, 2024 15:45
6e9e764
to
2677a88
Compare
sebr72
changed the title
Use getRawStatusCode to don't get an exception on fake status code 999, convert it to 406 Not Acceptable
Use getRawStatusCode to avoid getting an exception on fake status code 999, convert it to 406 Not Acceptable
Nov 1, 2024
sebr72
force-pushed
the
no-exception
branch
2 times, most recently
from
November 3, 2024 02:00
5a0e1c7
to
e07994a
Compare
sebr72
approved these changes
Nov 3, 2024
Is it ready to be merged? |
@sbrunner If you are satisfied with my changes, please go ahead with the merge. |
sbrunner
force-pushed
the
no-exception
branch
from
November 4, 2024 08:28
e07994a
to
80e443d
Compare
sbrunner
force-pushed
the
no-exception
branch
from
November 4, 2024 08:29
80e443d
to
acc16dc
Compare
c2c-bot-gis-ci-2
removed
the
backport master
Backport the pull request to the 'master' branch
label
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.