Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: improve instructions for scaling configuration #3408

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

jwkaltz
Copy link
Contributor

@jwkaltz jwkaltz commented Sep 12, 2024

No description provided.

@jwkaltz jwkaltz requested review from sbrunner and sebr72 September 12, 2024 11:30
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. But it makes sense to merge the 2 commits since the second one is the pre-commit fix.

@jwkaltz jwkaltz force-pushed the improve_scaling_documentation branch from fae60b0 to 1db03bd Compare September 12, 2024 14:12
@jwkaltz jwkaltz requested a review from sebr72 September 12, 2024 14:12
@jwkaltz
Copy link
Contributor Author

jwkaltz commented Sep 13, 2024

@sebr72 I have addressed the requested changes, but GitHub

Looks good. Thanks. But it makes sense to merge the 2 commits since the second one is the pre-commit fix.

@sebr72 I have addressed the requested changes, but I don't see how I can resolve the conversation in GitHub. Can you please have a look?

jwkaltz and others added 2 commits September 13, 2024 14:39
From the artifact of the previous workflow run
@jwkaltz jwkaltz merged commit 1256357 into master Sep 13, 2024
9 checks passed
@jwkaltz jwkaltz deleted the improve_scaling_documentation branch September 13, 2024 12:55
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants