Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding in pretty mode #3373

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Fix encoding in pretty mode #3373

merged 1 commit into from
Aug 10, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 9, 2024

Fix #3266

@sbrunner sbrunner requested a review from sebr72 August 9, 2024 13:27
sebr72
sebr72 requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please check this inside test, to make sure we won't break it in future. ;-)

@sbrunner sbrunner force-pushed the encoding branch 7 times, most recently from e5d53d1 to fcc1a4b Compare August 9, 2024 16:14
@sebr72 sebr72 self-requested a review August 9, 2024 16:22
@sbrunner
Copy link
Member Author

sbrunner commented Aug 9, 2024

Done :-)

sebr72
sebr72 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sebr72 sebr72 marked this pull request as ready for review August 9, 2024 18:55
@sbrunner sbrunner merged commit 5db375c into master Aug 10, 2024
9 checks passed
@sbrunner sbrunner deleted the encoding branch August 10, 2024 19:34
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebr72 sebr72 sebr72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.31.1
Development

Successfully merging this pull request may close these issues.

Get Capabilities pretty=true flag encoding issue
2 participants
@sbrunner @sebr72