Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase cleanup. Bug fixes #3288

Merged
merged 6 commits into from
May 21, 2024
Merged

Codebase cleanup. Bug fixes #3288

merged 6 commits into from
May 21, 2024

Conversation

sebr72
Copy link
Contributor

@sebr72 sebr72 commented May 17, 2024 •
edited
Loading

  1. Avoid running testpdfA twice. Introduce new list to validate pdfs.
  2. Fix bug stopping method from being transactional
  3. Make inner classes static to avoid memory leaks
  4. Improve logging messages
  5. Improve performance using empty arrays. Also remove data race risk between the size and toArray calls
  6. Remove dead code

@sebr72 sebr72 changed the title To try stuff Codebase cleanup. Bug fixes May 21, 2024
@sebr72 sebr72 marked this pull request as ready for review May 21, 2024 10:51
@sebr72 sebr72 enabled auto-merge May 21, 2024 11:05
@sebr72 sebr72 merged commit 97fee55 into master May 21, 2024
5 checks passed
@sebr72 sebr72 deleted the trystuff branch May 21, 2024 11:24
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
@sbrunner sbrunner added the bug Something isn't working label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.31.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sebr72 @sbrunner