Improve class management and bug fixes #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sebr72
commented
May 10, 2024
•
sebr72
commented
- Fix Post commands in the test CLI
- Autoclose timers
- Reorganise configurations for docs and acceptancetests
- Remove inner classes and reduce code duplication
- Remove deprecated classes
- Remove security threats (unsafe code)
- Fix small bugs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/src/main/java/org/mapfish/print/servlet/HandleReportLoadResult.java
Fixed
Show fixed
Hide fixed
core/src/main/java/org/mapfish/print/servlet/HandleReportLoadResult.java
Fixed
Show fixed
Hide fixed
core/src/main/java/org/mapfish/print/servlet/HandleReportLoadResult.java
Fixed
Show fixed
Hide fixed
core/src/main/java/org/mapfish/print/servlet/HandleReportLoadResult.java
Fixed
Show fixed
Hide fixed
sbrunner
approved these changes
May 15, 2024
There was a problem hiding this comment.
Looks good, just the issue:
One commit cass: https://github.com/mapfish/mapfish-print/pull/3284/checks?check_run_id=25008836314
and for the CodeQL issue it can be done in another pull request (as you want :-) )
sbrunner
reviewed
May 16, 2024
core/jettyRunExtraFiles/mapfish-spring-application-context-override.xml
Outdated
Show resolved
Hide resolved
sebr72
changed the title
sbrunner
approved these changes
May 16, 2024
sbrunner
reviewed
May 17, 2024
...traConfigFor/acceptanceTests/mapfish-spring-application-context-override-acceptancetests.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.