Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory related cleanups #3268

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Memory related cleanups #3268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/org/mapfish/print/http/HttpRequestFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ public void close() {
try {
this.body.close();
} catch (IOException e) {
// ignored
LOGGER.warn("Failed to close body", e);
} finally {
this.body = null;
}
}
}
Expand Down
6 changes: 0 additions & 6 deletions core/src/main/java/org/mapfish/print/http/MfClientHttpRequestFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,6 @@ public String getStatusText() {
return this.response.getStatusLine().getReasonPhrase();
}

@Override
protected void finalize() throws Throwable {
super.finalize();
close();
}

@Override
public void close() {
try {
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/org/mapfish/print/map/tiled/CoverageTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ protected Tile compute() {
TilePreparationTask.class.getName()
+ ".read."
+ StatsUtils.quotePart(this.tileRequest.getURI().getHost());
LOGGER.debug("\n\t{} -- {}", this.tileRequest.getMethod(), this.tileRequest.getURI());
LOGGER.debug("{} -- {}", this.tileRequest.getMethod(), this.tileRequest.getURI());
final Timer.Context timerDownload = this.registry.timer(baseMetricName).time();
try (ClientHttpResponse response = this.tileRequest.execute()) {
final HttpStatus statusCode = response.getStatusCode();
Expand Down