Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application ID in the JSON logs #2941

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Add application ID in the JSON logs #2941

merged 1 commit into from
Aug 15, 2023

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner force-pushed the add-application_id branch 7 times, most recently from 778b553 to 91b1b1a Compare May 16, 2023 16:41
@sbrunner sbrunner changed the base branch from 3.30 to master May 16, 2023 16:41
@sbrunner sbrunner force-pushed the add-application_id branch 2 times, most recently from 2e636ad to c836fdd Compare May 17, 2023 06:27
@sbrunner sbrunner requested a review from sebr72 May 17, 2023 07:40
@sbrunner
Copy link
Member Author

One thing we can change to improve it is to use [getCopyOfContextMap](https://www.slf4j.org/api/org/slf4j/MDC.html#getCopyOfContextMap--) and setContextMap to pass a context map instance of an application id and a job id...

@sebr72 sebr72 marked this pull request as draft May 31, 2023 07:28
@sbrunner sbrunner force-pushed the add-application_id branch 13 times, most recently from 99d8ecb to adc988b Compare June 8, 2023 18:50
@sbrunner
Copy link
Member Author

sbrunner commented Jun 8, 2023 •
edited
Loading

@sebr72 did you see the two violation I added?

@sbrunner sbrunner marked this pull request as ready for review June 8, 2023 18:51
@sbrunner sbrunner requested a review from sebr72 June 9, 2023 13:34
@sbrunner sbrunner requested a review from sebr72 June 28, 2023 07:15
@sbrunner sbrunner force-pushed the add-application_id branch from adc988b to 1956a96 Compare August 15, 2023 16:21
@sbrunner sbrunner force-pushed the add-application_id branch from 1956a96 to e08c166 Compare August 15, 2023 16:34
@sbrunner sbrunner merged commit a62d1a5 into master Aug 15, 2023
@sbrunner sbrunner deleted the add-application_id branch August 15, 2023 18:02
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebr72 sebr72 sebr72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.31.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @sebr72