Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom User-Agent for MapFishPrint. #2020

Merged
1 commit merged into from
Sep 22, 2021
Merged

Add custom User-Agent for MapFishPrint. #2020

1 commit merged into from
Sep 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2021

This fixes #1955

@ghost ghost requested review from danduk82 and sbrunner August 19, 2021 18:16
@ghost
Copy link
Author

ghost commented Aug 19, 2021

The User-Agent is built up by MapFishPrint/<version> plus the original User-Agent from HttpClient:

User-Agent: MapFishPrint/3.29.0-SNAPSHOT Apache-HttpClient/4.5.13 (Java/1.8.0_292)

@ghost ghost force-pushed the issue-1955_v2 branch from a7cdc3f to ebaf680 Compare August 19, 2021 18:21
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark, also that looks good :-)

@@ -1,4 +1,5 @@
import org.apache.tools.ant.taskdefs.condition.Os
import org.apache.tools.ant.filters.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we specify the needed classes?

@ghost ghost force-pushed the issue-1955_v2 branch from ebaf680 to 48320d0 Compare September 18, 2021 19:53
@ghost ghost force-pushed the issue-1955_v2 branch from 48320d0 to 56334cc Compare September 18, 2021 19:57
@ghost ghost merged commit 79a90c7 into master Sep 22, 2021
@ghost ghost deleted the issue-1955_v2 branch September 22, 2021 15:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect User-Agent sent by Mapfish to OSM tileservers
1 participant