Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes #1774

Merged
2 commits merged into from Mar 19, 2021
Merged

Add release notes #1774

2 commits merged into from Mar 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2021

No description provided.

@ghost ghost requested a review from sbrunner March 18, 2021 14:17
README.md Outdated

[War and jar from version 3.23](https://github.com/orgs/mapfish/packages)
[War and jar from version 3.23](https://github.com/mapfish/mapfish-print/releases)
Copy link
Member

@sbrunner sbrunner Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The war and jar are in packages, not in releases...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The releases also contain the war and jar, besides all other things, like in:

https://github.com/mapfish/mapfish-print/releases/tag/3.28.0

Assets 7
print-cli-3.28.0.zip
103 MB
print-lib-3.28.0-javadoc.jar
2.01 MB
print-lib-3.28.0-sources.jar
527 KB
print-lib-3.28.0.jar
877 KB
print-servlet-3.28.0.war
103 MB
Source code (zip)
Source code (tar.gz)

Conversely, the "packages" section is really wired:

On https://github.com/mapfish/mapfish-print the link "Packages" on the right side brings you to a general mapfish-page:

Here only three packages of the old 3.26 release are available:

https://github.com/orgs/mapfish/packages?repo_name=mapfish-print

That was the reason I changed this.

What is correct now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The releases also contain the war and jar, besides all other things, like in:

Oups, I didn't see them because the asses are closed.

Conversely, the "packages" section is really wired:

Effectively, the GitHub UI can be improved..., but we can fill the description :-)

Here only three packages of the old 3.26 release are available:

Oups, it seem that the command ./gradlew publish is dropped by error in this commit ...
b261051#diff-ca012d969385d0ed162c422aab9ab523ba77567277a4a8bc534dfcf5a6b3c2fcL30

What is correct now?

The link on packages are required because it's usable with Maven :-)
The release link is optional :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added both packages and releases.
You fix the build script for packages?

@ghost ghost merged commit 5d8765f into mapfish:master Mar 19, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant