Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta tiling support #1718

Merged
merged 13 commits into from
Feb 12, 2021
Merged

Add meta tiling support #1718

merged 13 commits into from
Feb 12, 2021

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Feb 11, 2021 •
edited
Loading

To do:

  • Add tile buffer param to request bigger tile
  • Crop the requested tile to get the original tile size

sbrunner
sbrunner reviewed Feb 11, 2021
View reviewed changes
core/src/main/java/org/mapfish/print/map/tiled/wms/TiledWmsLayerParam.java Outdated
@@ -18,6 +18,7 @@
* A two element array of integers indicating the x and y size of each tile.
*/
public int[] tileSize;
public int[] tileBufferSize;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably @HasDefaultValue is missing ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: https://github.com/mapfish/mapfish-print/runs/1880797374?check_suite_focus=true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added.

@sbrunner
Copy link
Member

@ismailsunni I just do a rebase :-), I also run the CI on pull request :-)

@dependabot-preview @ismailsunni
Bump c2cciutils in /ci
e35317b 
Bumps [c2cciutils](https://github.com/camptocamp/c2cciutils) from 1.0.dev20210212084346 to 1.0.dev20210212123011.
- [Release notes](https://github.com/camptocamp/c2cciutils/releases)
- [Commits](https://github.com/camptocamp/c2cciutils/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@sbrunner
Copy link
Member

@ismailsunni now there is some style error in your code ...

@sbrunner sbrunner merged commit e1ed3c9 into mapfish:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailsunni @sbrunner