Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings #39

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Add typings #39

merged 3 commits into from
Oct 18, 2021

Conversation

HarelM
Copy link
Contributor

@HarelM HarelM commented Oct 18, 2021

Added relevant code to support typescript.

mourner
mourner approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mourner mourner merged commit 788b783 into mapbox:main Oct 18, 2021
@HarelM
Copy link
Contributor Author

HarelM commented Oct 18, 2021

No problem :-) Thanks for the quick merge!
BTW, I tried to npm install this using the git link and I see that the d.ts file is not included.
I think it might be related to files: [] in package.json, but I'm not sure...
Let me know if you want me to try and send another PR for this...

@mourner
Copy link
Member

mourner commented Oct 18, 2021

Oops! Published v2.0.4, should be good now.

@HarelM
Copy link
Contributor Author

HarelM commented Oct 18, 2021

Thanks! Sorry for the partial fix... :-/

This was referenced Oct 18, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarelM @mourner