Skip to content

Commit

Permalink
attempt to fix node less than 16 which contains older node-gyp before…
Browse files Browse the repository at this point in the history
… 0.6.0 release - refs nodejs/node-gyp#2233
  • Loading branch information
Dane Springmeyer committed Oct 21, 2021
1 parent 6356cc7 commit 9572c26
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion test/app4/binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@
},
'msvs_settings': {
'VCCLCompilerTool': { 'ExceptionHandling': 1 },
}
},
# gyp inside node v16 uses -rpath=$ORIGIN/ instead of -rpath=$ORIGIN/lib.target/
# which fixes a longstanding descreptancy between platforms as documented at https://github.com/nodejs/node-gyp/issues/2233
# This allows tests to pass for older, still buggy and inconsistent versions of node-gyp (and will be duplicative for npm >= 7 which bundles node-gyp >= v0.6.0)
'ldflags': [
"-Wl,-rpath=\$$ORIGIN/"
],
},
{
"target_name": "action_after_build",
Expand Down

0 comments on commit 9572c26

Please sign in to comment.