fix node gyp from electron-spawn

mapbox · Apr 30, 2019 · 78c4a50 · 78c4a50
1 parent 1d019f9
commit 78c4a50
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/util/versioning.js b/lib/util/versioning.js
@@ -263,7 +263,8 @@ function get_process_runtime(versions) {
     var runtime = 'node';
     if (versions['node-webkit']) {
         runtime = 'node-webkit';
-    } else if (versions.electron) {
+    } else if (versions.electron || process.env.ELECTRON_RUN_AS_NODE) {
+        // Running in electron or a childProcess.fork of electron
         runtime = 'electron';
     }
     return runtime;

diff --git a/test/versioning.test.js b/test/versioning.test.js
@@ -77,6 +77,12 @@ test('should detect runtime for node-webkit and electron', function(t) {
         "node-webkit": '0.37.3',
     };
     t.equal(versioning.get_process_runtime(mock_process_versions3),'node-webkit');
+    var mock_process_versions4 = {
+        "node": '0.8.0',
+    };
+    process.env.ELECTRON_RUN_AS_NODE = 1;
+    t.equal(versioning.get_process_runtime(mock_process_versions4), 'electron');
+    delete process.env.ELECTRON_RUN_AS_NODE;
     t.end();
 });