expose metadata in protobuf #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think sdfPx=8 means that if you are 1px from the edge in the sdf then the distance value for that point is 8 A distance of 20 is 2.5 pixels from the edge |
tristen
added a commit
that referenced
this pull request
Aug 5, 2019
Pull what's applicable from #97 into this commit.
|
Closing this! progress continues in #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the proto spec to include both font face metadata and SDF generation metadata, and drops the "fontstack" concept from the proto spec. Although a font file can contain multiple faces, I'm undecided on whether the proto spec should still permit multiple faces.
Refs #51, mapbox/mapbox-gl-js#154, #80 (comment)
@ansis I still can't quite figure out where the magic
sdfPxvalue in mapbox-gl-js is originating from, please tag a commit on here if you can find it in the SDF generation code. IssdfPxused to calculate distance units per pixel and shift as mentioned in #51 or are those other constants I can't find?