Pass variables to replace tokens in query #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 64.08% 64.77% +0.69%
==========================================
Files 30 30
Lines 2230 2308 +78
==========================================
+ Hits 1429 1495 +66
- Misses 801 813 +12
Continue to review full report at Codecov.
|
added 4 commits
August 1, 2017 18:41
System test to make sure processor variables fully backwards compatible.
|
Thanks for this @rafatower! Nice work - looks great. Will merge now. |
rafatower
pushed a commit
to CartoDB/tilelive-bridge
that referenced
this pull request
Jan 9, 2018
Add some variables to be used later on by mapnik postgis input for token substitution. Note that the actual substitution depends on some changes in node-mapnik and mapnik-vector-tile: mapbox/mapnik-vector-tile#248 https://github.com/CartoDB/node-mapnik/blob/v3.6.2-carto/CHANGELOG.carto.md#362-carto1 CartoDB/node-mapnik#10
This was referenced Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #218 along with a minor change in node-mapnik
What this does:
mapnik::attributes varsto the mvt processor.processor::update_tileto thetile_layer, so that it can set the variables of its associated query from there (empty if not passed to the processor constructor).(thanks @Algunenano for the advice on the constructor)
This is the patch that would be required in node-mapnik to indeed pass the variables to the datasources. I haven't created a PR yet because it makes little sense until this one approved.