Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

[docs] Set defaults for product metadata #1331

Merged
merged 6 commits into from
Aug 7, 2020
Merged

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Jul 24, 2020

This PR will add defaults to the configuration to set the default values for platforms, services, and platforms. These values will be used internally.

To do:

  • Review by @colleenmcginnis to check that values are accurate.
  • Update docs-page-shell (Jekyll version) to handle these values (via {{page.products | jsonify}} {{page.services | jsonify}} {{page.platforms | jsonify}}).
  • Test on staging.

Ref https://github.com/mapbox/documentation/issues/479

@katydecorah
Copy link
Contributor Author

This branch is on staging.

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @katydecorah! One lil suggestion that I'll leave up to you. 🐊

_config.yml Outdated Show resolved Hide resolved
@katydecorah katydecorah marked this pull request as ready for review August 7, 2020 15:33
@katydecorah katydecorah merged commit 1db88e7 into publisher-production Aug 7, 2020
@katydecorah katydecorah deleted the metadata branch August 7, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants