Move context blitting operation to a dispatch queue with a barrier #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… safeguard against concurrency problems. CGCentexts are not threadsafe and this caused occasional crashes as tile images were returned and stiched together.
|
@natalia-osa - Any comments? |
|
Seems fine. But I cannot test it because I still have 100% crashes with the code (from this branch or from master). If you wanted to fix my issue, it doesn't look like the reason. Here is the description of crash happening for for 100% sessions for us: #62 (comment). It's also the reason why we're not up to date with your code. |
|
Are there any updates on this pull request? I was about to put a up a pull request with the same fix, as this fixes one of several crashes happening in my project. |
|
Thanks! That was a really quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safeguard against concurrency problems. CGContexts are not thread-safe and this caused occasional crashes as tile images were returned and stitched together.