Bearing Animation #325
Closed
Bearing Animation #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Feb 28, 2018
| @@ -102,16 +92,18 @@ public void onAnimationUpdate(ValueAnimator valueAnimator) { | |||
| } | |||
|
|
|||
| void cancelAllAnimations() { | |||
| cancelLocationAnimations(); | |||
| cancelLatLngAnimation(); | |||
| cancelCompassAnimations(); | |||
There was a problem hiding this comment.
cancelBearingAnimation() not called.
LukasPaczos
reviewed
Feb 28, 2018
| locationLayerAnimator.feedNewLocation(lastLocation, location); | ||
| LatLng previousLatLngTarget = new LatLng(lastLocation); | ||
| LatLng latLngTarget = new LatLng(location); | ||
| locationLayerAnimator.feedNewLatLng(previousLatLngTarget, latLngTarget); |
There was a problem hiding this comment.
Shouldn't previousLatLngTarget be taken from the current camera position, not from the last location?
LukasPaczos
reviewed
Feb 28, 2018
| LatLng latLngTarget = new LatLng(location); | ||
| locationLayerAnimator.feedNewLatLng(previousLatLngTarget, latLngTarget); | ||
|
|
||
| float previousGpsBearing = lastLocation.getBearing(); |
There was a problem hiding this comment.
Same as for previousLatLngTarget.
|
@danesfeder Added a couple of comments, maybe they'll help to pinpoint any issues you might have. |
|
Closing in favor of #349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.