Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching all plugins to AndroidX #1100

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

langsmith
Copy link
Contributor

This pr switches this repo's plugins and related files to AndroidX.

These changes follow the 9.0.0 Maps SDK release, which introduced AndroidX in https://github.com/mapbox/mapbox-gl-native-android/pull/129/files and went out in https://github.com/mapbox/mapbox-gl-native-android/releases/tag/android-v9.0.0-alpha.1

The Java SDK switch to AndroidX happened at mapbox/mapbox-java#1095 and went out in the 5.0.0 release: https://github.com/mapbox/mapbox-java/releases/tag/v5.0.0

@langsmith
Copy link
Contributor Author

Close to ✅

Current 💥 is about make generate-annotation-code
Screen Shot 2020-02-28 at 6 20 51 PM

Running make generate-annotation-code on my local machine adjusts the files back to the support import lines.
Screen Shot 2020-02-28 at 6 02 04 PM
Screen Shot 2020-02-28 at 6 02 10 PM

Need to hunt down the right place to adjust the scripting so that AndroidX lines are used instead

@langsmith langsmith force-pushed the ls-refactor-to-androidx branch from 7efecf0 to 139bbd2 Compare March 2, 2020 18:27
@langsmith langsmith marked this pull request as ready for review March 2, 2020 18:27
@langsmith langsmith self-assigned this Mar 2, 2020
@langsmith
Copy link
Contributor Author

CI is passing. Next step for me is to do manual QA of all plugins in this repo's test app.

@langsmith langsmith changed the title [WIP] Switching all plugins to AndroidX Switching all plugins to AndroidX Mar 2, 2020
@langsmith langsmith requested a review from tobrun March 2, 2020 18:48
@langsmith
Copy link
Contributor Author

All plugins are working as expected in the test app on this branch. We're good to go here @tobrun .

@langsmith langsmith added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label Mar 2, 2020
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work @langsmith 💪

@langsmith langsmith merged commit 83b1914 into master Mar 3, 2020
@langsmith langsmith deleted the ls-refactor-to-androidx branch March 3, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review When your PR has been personally reviewed, its time for an external contributors to approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants