Actively remove parens from voice instructions #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Jul 25, 2017
MapboxNavigation/String.swift
Outdated
| ("'", "'") | ||
| ("'", "'"), | ||
| ("(", ""), | ||
| (")", "") |
There was a problem hiding this comment.
This turns addingXMLEscapes into a misnomer. This method may be used in places where we just want to mark up XML and don’t want to remove parentheses. Instead of repurposing this method, let’s modify the call sites to remove parentheses.
MapboxNavigation/String.swift
Outdated
| ("'", "'") | ||
| ("'", "'"), | ||
| ("(", ""), | ||
| (")", "") |
There was a problem hiding this comment.
Along the lines of osmlab/osmlint#234, are there any other characters that we should strip out?
|
@1ec5 updated. |
1ec5
reviewed
Jul 25, 2017
MapboxNavigation/String.swift
Outdated
| ]) | ||
| } | ||
|
|
||
| var withoutPuncation: String { |
There was a problem hiding this comment.
removingPunctuation would be more in keeping with existing String methods.
mappy-mobile
pushed a commit
to Mappy/mapbox-navigation-ios
that referenced
this pull request
Sep 17, 2020
Use Result for directions response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we find a fix upstream, we should omit parens completely from a voice instruction.
/cc @1ec5