-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Turf v0.5.0 #2393
Update Turf v0.5.0 #2393
Conversation
@@ -17,12 +17,17 @@ extension MGLPointFeature { | |||
/** | |||
Initializes a map point feature representation of the given Turf point feature. | |||
|
|||
- parameter pointFeature: The Turf point feature to convert to a map point feature. | |||
- parameter pointFeature: The Turf `Point` feature to convert to a map point feature. If the Feature passed is not of type `Point` - initialization fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunate, but it’s a consequence of mapbox/mapbox-gl-native#7454 rather than any issue on the navigation side. I wonder if we should add a more generic standalone function that converts between Feature and MGLFeature. But this works for now.
Currently, there a two source-code level issues, blocking the build, induced by junction views. |
d4b0415
to
5dacdb4
Compare
@Udumft I fixed the issues related to guidance views. |
Looks like there is a need to update
I've encountered this warning while trying to update dependencies versions, and in fact there was an error parsing the |
@@ -29,7 +29,7 @@ DEPENDENCIES: | |||
- MapboxNavigation (from `../../../`) | |||
|
|||
SPEC REPOS: | |||
trunk: | |||
https://github.com/cocoapods/specs.git: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this has been a longstanding annoyance for us. To keep the trunk
repo from being a problem in the future, we’d need to ensure that the CI bots are all running a newer version of CocoaPods that can handle trunk
. Some of the older-Xcode CI bots are on images that come with older CocoaPods versions. We could either manually upgrade CocoaPods on those bots as part of the build process, or we could upgrade those bots to a newer-Xcode image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just rebase master.
Updates Turf dependency to v0.5.0.
Update source code to reflect new types, removed workaround
mapbox/turf-swift/pull/79
, removedMGFeature
convenience initializators.TODO:
Directions
to include Turf updateDirections
, requiring Nav SDK updates.CI builds will fail unless dependencies are bumped.