Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turf v0.5.0 #2393

Merged
merged 15 commits into from
Jun 17, 2020
Merged

Update Turf v0.5.0 #2393

merged 15 commits into from
Jun 17, 2020

Conversation

Udumft
Copy link
Contributor

@Udumft Udumft commented Jun 8, 2020

Updates Turf dependency to v0.5.0.

Update source code to reflect new types, removed workaroundmapbox/turf-swift/pull/79, removed MGFeature convenience initializators.

TODO:

  • Update Directions to include Turf update
  • Watch out for other API updates in Directions, requiring Nav SDK updates.

CI builds will fail unless dependencies are bumped.

@Udumft Udumft added the build Issues related to builds and dependency management. label Jun 8, 2020
@Udumft Udumft requested review from 1ec5 and MaximAlien June 8, 2020 13:54
@Udumft Udumft self-assigned this Jun 8, 2020
MapboxCoreNavigation/RouteLeg.swift Outdated Show resolved Hide resolved
@@ -17,12 +17,17 @@ extension MGLPointFeature {
/**
Initializes a map point feature representation of the given Turf point feature.

- parameter pointFeature: The Turf point feature to convert to a map point feature.
- parameter pointFeature: The Turf `Point` feature to convert to a map point feature. If the Feature passed is not of type `Point` - initialization fails.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate, but it’s a consequence of mapbox/mapbox-gl-native#7454 rather than any issue on the navigation side. I wonder if we should add a more generic standalone function that converts between Feature and MGLFeature. But this works for now.

@Udumft Udumft changed the title Update Turf v0.4.0 Update Turf v0.5.0 Jun 11, 2020
@Udumft Udumft requested a review from fabian-guerra June 12, 2020 10:03
@Udumft
Copy link
Contributor Author

Udumft commented Jun 15, 2020

Currently, there a two source-code level issues, blocking the build, induced by junction views.
These two cases do not handle new .guidanceView case.

cc @fabian-guerra

@fabian-guerra
Copy link
Contributor

@Udumft I fixed the issues related to guidance views.

@Udumft
Copy link
Contributor Author

Udumft commented Jun 16, 2020

Looks like there is a need to update pod version.

[!] The version of CocoaPods used to generate the lockfile (1.8.4) is higher than the version of the current executable (1.6.1). Incompatibility issues may arise.

I've encountered this warning while trying to update dependencies versions, and in fact there was an error parsing the Podfile.lock which resulted in CI fail. After applying some compatibility fix it worked.

@Udumft Udumft marked this pull request as ready for review June 16, 2020 13:29
@Udumft Udumft requested review from 1ec5 and MaximAlien June 16, 2020 13:29
@@ -29,7 +29,7 @@ DEPENDENCIES:
- MapboxNavigation (from `../../../`)

SPEC REPOS:
trunk:
https://github.com/cocoapods/specs.git:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this has been a longstanding annoyance for us. To keep the trunk repo from being a problem in the future, we’d need to ensure that the CI bots are all running a newer version of CocoaPods that can handle trunk. Some of the older-Xcode CI bots are on images that come with older CocoaPods versions. We could either manually upgrade CocoaPods on those bots as part of the build process, or we could upgrade those bots to a newer-Xcode image.

Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just rebase master.

@Udumft Udumft merged commit 4a5d1bf into master Jun 17, 2020
@Udumft Udumft deleted the vk-turf-update branch June 17, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants