Added onOffRoute call and removed queue from NavigationInstructionPlayer #986
Conversation
There was a problem hiding this comment.
@devotaaabel so the queue in NavigationInstructionPlayer wasn't necessary? This shouldn't affect any queueing / caching right?
| public class NavigationInstructionPlayer implements InstructionListener { | ||
|
|
||
| private AudioManager instructionAudioManager; | ||
| private AudioFocusRequest instructionFocusRequest; | ||
| private MapboxSpeechPlayer mapboxSpeechPlayer; | ||
| private AndroidSpeechPlayer androidSpeechPlayer; | ||
| private Queue<VoiceInstructionMilestone> instructionQueue; | ||
| VoiceInstructionMilestone voiceInstructionMilestone; |
There was a problem hiding this comment.
Does it make sense to store the String voiceInstructionMilestone.getAnnouncement() here instead of the milestone? Also this field can be private rather than package-private.
There was a problem hiding this comment.
@danesfeder no because we need both the announcement and the ssmlAnnouncement
There was a problem hiding this comment.
Ah okay, wasn't sure because ssmlAnnouncement is immediately passed to:
mapboxSpeechPlayer.play(voiceInstructionMilestone.getSsmlAnnouncement());
devotaaabel
force-pushed
the
devota-add-on-off-route-call
branch
from
a0d778c
to
5d85b1c
Compare
|
@danesfeder no it shouldn't affect the caching, that happens in |
devotaaabel
force-pushed
the
devota-add-on-off-route-call
branch
from
5d85b1c
to
7c2d676
Compare
Removed the queue from
NavigationInstructionPlayerafter realizing that everyVoiceInstructionMilestonewas the same instance. Added the onOffRoute call toNavigationViewModel.