-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update localization.md #913
Conversation
localization.md
Outdated
| Hebrew | ✅ | - | ||
| Italian | ✅ | ✅ | ||
| Korean | ✅ | — | ||
| Portuguese(Portugese) | ✅ | ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Portugese” is misspelled. We support both Brazilian and European Portuguese in the iOS navigation SDK, but I decided not to list the dialects in the iOS language support document, because users of both dialects will still get Portuguese instead of English.
localization.md
Outdated
| English | ✅ | ✅ | ||
| French | ✅ | ✅ | ||
| German | ✅ | ✅ | ||
| Hebrew | ✅ | - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave a
-
to spoken instructions, where iOS is marked as "manual".
“Manual” refers to the fact that the iOS navigation SDK won’t automatically use a language if the UI isn’t already in that language. But my understanding is that the Android navigation SDK will, for instance, deliver Turkish instructions even though the UI is unavailable in Turkish. So if we were to draw parallels between Android and iOS, it would look like this:
iOS | Android |
---|---|
Manual | ✔️ |
Uses VoiceOver | Depends on the device; may require third-party text-to-speech |
Requires third-party text-to-speech | Depends on the device; may require third-party text-to-speech |
Should I remark that these languages will immediately use
TextToSpeech
and if the speech engine for the givenLocale
is not installed on the device, pronunciation will fail?
Yes. I think we need a way to distinguish between these two cases:
- We have no way of providing instructions in the language.
- We can provide instructions in the language, but it’s up to the device or a third-party text-to-speech engine to speak it.
For the first case, — is appropriate. But for the second case, how about a ✅ with a remark about text-to-speech depending on the device. We’d be adding several rows to this table, including Chinese.
Also, let’s link to the contributing guide, so readers know that if they really need another language, there’s something they can do about it. |
localization.md
Outdated
| Vietnamese | - | ✅ | ✅ | ||
The table below lists the languages that are supported for user interface elements and for spoken instructions. | ||
|
||
| Language | User interface | [Spoken instructions][osrmti] | Remarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional: [Spoken instructions][osrmti]
?
6b6d83f
to
1925aae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments below about formatting, but the content looks good to go.
localization.md
Outdated
| Vietnamese | - | ✅ | ✅ | ||
The table below lists the languages that are supported for user interface elements and for spoken instructions. | ||
|
||
| Language | User interface | [Spoken instructions](https://www.mapbox.com/api-documentation/#instructions-languages) | Remarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, there’s an alternative footnote syntax for linking that looks like this: [Spoken instructions][apidoc]
, followed by [apidoc]: https://…
on its own line at the end of the document. I use this syntax inside tables to keep the layout organized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1ec5 awesome thanks!
localization.md
Outdated
|
||
See the [contributing guide](https://github.com/mapbox/mapbox-navigation-ios/blob/master/CONTRIBUTING.md#adding-or-updating-a-localization) for instructions on adding a new localization or improving an existing localization. | ||
|
||
[osrmti]: https://www.mapbox.com/api-documentation/#instructions-languages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the URL would go.
localization.md
Outdated
| Chinese | - | ✅ Mandarin | Depends on the device; may require third-party text-to-speech | ||
| Czech | ✅ | - | ||
| Danish | ✅ | ✅ | ||
| French | ✅ | ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This row is out of alphabetical order.
@1ec5 Refreshing this table with the latest changes from Transifex. I only gave a ✅ to the UI languages 100% translated. I gave a
-
to spoken instructions, where iOS is marked as "manual".Should I remark that these languages will immediately use
TextToSpeech
and if the speech engine for the givenLocale
is not installed on the device, pronunciation will fail?cc @brsbl